[CAUTH-511] improve error handling on missing captcha #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfromaniello
changed the title
mhsu-auth0
reviewed
Jul 13, 2020
| @@ -54,7 +54,7 @@ export default class CaptchaInput extends React.Component { | |||
| </div> | |||
| <InputWrap | |||
| focused={focused} | |||
| invalidHint={invalidHint} | |||
| invalidHint="" | |||
There was a problem hiding this comment.
No, this is actually intended.. The component is generic and it requires an invalidHint parameter, the invalidHint text is shared for all components.
Tony suggested this text get replaced here and I didn't know what to use
I think it doesn't look bad for the auth0 case, since the description is above like in the header of the widget
mhsu-auth0
previously approved these changes
Jul 13, 2020
jfromaniello
force-pushed
the
improve_error_handling_captcha
branch
2 times, most recently
from
d13a640
to
b36154b
Compare
jfromaniello
force-pushed
the
improve_error_handling_captcha
branch
from
b36154b
to
36d394f
Compare
stevehobbsdev
requested changes
Jul 16, 2020
| @@ -7,7 +7,7 @@ import * as l from '../../core/index'; | |||
| import { swap, updateEntity } from '../../store/index'; | |||
| import * as captchaField from '../captcha'; | |||
| import { getFieldValue, isFieldVisiblyInvalid } from '../index'; | |||
| import { ReCAPTCHA } from './recaptchav2'; | |||
| import { ReCAPTCHA } from './recaptchav2.jsx'; | |||
There was a problem hiding this comment.
Why is it necessary to include the extension here? We don't appear to need to do this in other places.
Comment on lines
+13
to
+14
| invalid_captcha: 'Solve the challenge question to verify you are not a robot.', | ||
| invalid_recaptcha: 'Select the checkbox to verify you are not a robot.', |
There was a problem hiding this comment.
We may need to provide additional translations for these, at least for the supported EU countries. I will ping you an internal conversation for context.
jfromaniello
force-pushed
the
improve_error_handling_captcha
branch
from
c909a2c
to
09dbcad
Compare
jfromaniello
force-pushed
the
improve_error_handling_captcha
branch
from
09dbcad
to
da77d6b
Compare
stevehobbsdev
approved these changes
Jul 16, 2020
stevehobbsdev
approved these changes
Jul 16, 2020
Merged
jfromaniello
added a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
* improve error handling on captcha * improve translation scripts * add missing translations
This was referenced Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull-request improve the error handling for both types of captcha. I am attaching here two gifs:
Also we raise the error before sending the request to the server side to avoid a round trip.
References
https://auth0team.atlassian.net/browse/CAUTH-511
Testing
I've tested this manually.
Checklist