Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run tests on browserstack #2405

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Do not run tests on browserstack #2405

merged 2 commits into from
Jul 17, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Jul 17, 2023 •
edited
Loading

Changes

The tests on BS are very unreliable. Since we only run them on chrome, we should be okay to run them locally (on CI) using Karma instead.

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner July 17, 2023 10:53
@frederikprijck frederikprijck enabled auto-merge (squash) July 17, 2023 10:55
@frederikprijck frederikprijck merged commit 280801a into master Jul 17, 2023
7 checks passed
@frederikprijck frederikprijck deleted the fix/ci-order branch July 17, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frederikprijck @stevehobbsdev