use ReactCSSTransitionGroup for global messages #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code looked like quite a mess with its .style this and .style that. This change lets the CSS do what it's good at and keeps the JS looking a bit cleaner in that file. It also cuts down on a dependency.
| height 0 | ||
| paddingTop 0 | ||
| paddingBottom 0 | ||
| &.global-message-enter.example-enter-active |
There was a problem hiding this comment.
What is .example-enter-active for?
There was a problem hiding this comment.
D'oh. That's from my testing; I forgot to replace it out. It's fixed now.
|
Hey, just curious: what is your release cycle like? When will a pull like this shows up in the NPM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global_message.jsx's code for componentWillEnter and componentWillLeave looked like quite a mess with the .style.this and .style.that. This change lets the CSS do what it's good at and keeps the JS looking a bit cleaner in that file.It also cuts down on a dependency.