MFA when using oauth/ro endpoint #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafortune
commented
Sep 30, 2016
| @@ -14,6 +14,8 @@ export default { | |||
| "lock.network": "We could not reach the server. Please check your connection and try again.", | |||
| "lock.popup_closed": "Popup window closed. Try again.", | |||
| "lock.unauthorized": "Permissions were not granted. Try again.", | |||
| "lock.mfa_registration_required": "Multifactor authentication is required but your device is not enrolled. Please enroll it before moving on.", | |||
There was a problem hiding this comment.
Not sure what to say in this case; we don't support enrollment. "Enrollment not supported"?
dafortune
force-pushed
the
add-mfa-code-input
branch
5 times, most recently
from
6ccff4b
to
69f3b65
Compare
We will show MFA screen when mfa is required for an user and the customer is using the /ro endpoint instead of popup or redirect mode (push notifications not allowed).
dafortune
force-pushed
the
add-mfa-code-input
branch
from
69f3b65
to
01a1b96
Compare
|
Why just update src/i18n/en.js & src/i18n/es.js ? I get many warnings in fr locale..
|
|
@narwajea you can add |
|
Thank you for the suggestion, but still why not updating all language files ? |
|
Yes we are working on it, but there are a lot of languages and we are trying to avoid using google translate to assure the quality of the translation. If you are fluent in french and want to collaborate PRs are always welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables lock to use MFA for ajax calls to the RO endpoint.
The basic configuration to support this use case is:
The result is that in case of mfa required we will show a new screen:
