Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client secret to passwordGrant #217

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

petetnt
Copy link
Contributor

@petetnt petetnt commented Oct 25, 2017

Should fix #210 and #195

Signed-off-by: petetnt pete.a.nykanen@gmail.com

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
@petetnt
Copy link
Contributor Author

petetnt commented Oct 25, 2017

Unless it should not have client_secret in which case the the docs are wrong

@james-gardner
Copy link

james-gardner commented Nov 1, 2017

Depends on how the client is configured. I put this up a couple of weeks ago:

#209

No tests though.

@james-gardner
Copy link

I've gone with writing my own calls using node-fetch. Could of forked off of this but there's not much momentum to work through pull requests.

@luisrudge luisrudge merged commit dd7ea03 into auth0:master Feb 28, 2018
@petetnt petetnt deleted the add-client-secret-to-password-grant branch February 28, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple errors in AuthenticationClient.passwordGrant documentation
3 participants