Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize Error Request Data #424

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Sanitize Error Request Data #424

merged 1 commit into from
Sep 13, 2019

Conversation

davidpatrick
Copy link
Contributor

Sanitizes sensitive error request data

Changes

  • Adds Errors module to introduce new error handling
  • New Error SanitizedError sanitizes sensitive request data

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@davidpatrick davidpatrick requested a review from a team September 9, 2019 16:46
@davidpatrick davidpatrick added small Small review enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature labels Sep 9, 2019
damieng
damieng reviewed Sep 9, 2019
View reviewed changes
src/errors.js Outdated Show resolved Hide resolved
@davidpatrick
Sanitize Error Request Data
a186023 
Sanitizes sensitive error request data
@davidpatrick davidpatrick merged commit b4fa1f3 into auth0:master Sep 13, 2019
@davidpatrick davidpatrick deleted the sanitizeRequestData branch September 13, 2019 22:11
@davidpatrick davidpatrick added this to the v2.20.0 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Security enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature small Small review
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpatrick @damieng