Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved OIDC compliance #446

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Improved OIDC compliance #446

merged 7 commits into from
Jan 15, 2020

Conversation

davidpatrick
Copy link
Contributor

Changes

This update improves the SDK support for OpenID Connect. In particular, it improves the ID Token Validation checks.

References

Internal Docs

Testing

  • This change adds test coverage

  • This change has been tested on the latest stable version of Node.js

Checklist

@davidpatrick davidpatrick requested a review from a team January 13, 2020 05:10
@stevehobbsdev stevehobbsdev added the medium Medium review label Jan 13, 2020
stevehobbsdev
stevehobbsdev reviewed Jan 13, 2020
View reviewed changes
Copy link

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just had a couple of questions.

test/idToken.tests.js Outdated Show resolved Hide resolved
test/idToken.tests.js Outdated Show resolved Hide resolved
@stevehobbsdev stevehobbsdev requested a review from a team January 13, 2020 11:44
@lbalmaceda lbalmaceda self-requested a review January 13, 2020 16:49
lbalmaceda
lbalmaceda suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, added a few comments for missing test. What is the reason not to delegate the verification to idtoken-verifier library, if that's possible?

test/auth/oauth-with-idtoken-validation.tests.js Show resolved Hide resolved
test/idToken.tests.js Outdated Show resolved Hide resolved
@davidpatrick davidpatrick merged commit 38f986c into auth0:master Jan 15, 2020
@davidpatrick davidpatrick added this to the v2.21.0 milestone Jan 15, 2020
@davidpatrick davidpatrick mentioned this pull request Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

@stevehobbsdev stevehobbsdev Awaiting requested review from stevehobbsdev

Assignees
No one assigned
Labels
CH: Added medium Medium review
Projects
None yet
Milestone
v2.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidpatrick @stevehobbsdev @lbalmaceda