Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return response.data where Axios is used #484

Merged
merged 2 commits into from
May 3, 2020
Merged

Return response.data where Axios is used #484

merged 2 commits into from
May 3, 2020

Conversation

taylorbryant
Copy link
Contributor

@taylorbryant taylorbryant commented May 1, 2020

Changes

In #475, the request library was removed in favor of Axios. This introduced a bug that causes the full HTTP response to be returned instead of just the data property from the response.

This PR updates anywhere Axios is used to explicitly grab the data property from the response.

References

Closes #483

Checklist

@taylorbryant taylorbryant requested a review from a team May 1, 2020 19:46
@taylorbryant taylorbryant changed the title Return reponse.data where Axios is used Return response.data where Axios is used May 2, 2020
Not needed on this call
@davidpatrick
Copy link
Contributor

Thank you @taylorbryant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthenticationClient.getProfile returns full HTTP response object
3 participants