Create .npmignore #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to [keep npm fit](https://medium.com/@goldglovecb/npm-needs-a-personal-trainer-537e0f8859c6). Specifically, the `test` directory and `DEVELOPMENT.md` really don't seem necessary in the production package.
|
👎 this just remove some kbs but prevents reading the README and tests from disk. I prefer reading readmes from disk because it might be different to the version on github or npmjs. |
|
This doesn't remove the README... it is a protected file (read the article, or the citation on npm). Test files have no place in production, especially in a package dealing with security. And yes, it does shrink the size of the package... that's part of the point. |
|
Since it keeps the readme and license this seems good to me. @jfromaniello? |
|
Makes even more sense now that we're storing all examples here instead of on a different repository. Feel free to revert if not needed. Thanks! |
|
We are moving the examples out soon, but I think either way it is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to keep npm fit. Specifically, the
testdirectory andDEVELOPMENT.mdreally don't seem necessary in the production package.