Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .npmignore #74

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Create .npmignore #74

merged 1 commit into from
Apr 12, 2016

Conversation

coreybutler
Copy link
Contributor

In an effort to keep npm fit. Specifically, the test directory and DEVELOPMENT.md really don't seem necessary in the production package.

In an effort to [keep npm fit](https://medium.com/@goldglovecb/npm-needs-a-personal-trainer-537e0f8859c6). Specifically, the `test` directory and `DEVELOPMENT.md` really don't seem necessary in the production package.
@jfromaniello
Copy link
Member

👎 this just remove some kbs but prevents reading the README and tests from disk. I prefer reading readmes from disk because it might be different to the version on github or npmjs.

@coreybutler
Copy link
Contributor Author

This doesn't remove the README... it is a protected file (read the article, or the citation on npm). Test files have no place in production, especially in a package dealing with security. And yes, it does shrink the size of the package... that's part of the point.

@ntotten
Copy link
Contributor

ntotten commented Mar 23, 2016

Since it keeps the readme and license this seems good to me. @jfromaniello?

@rolodato rolodato merged commit c5a228c into auth0:master Apr 12, 2016
@rolodato
Copy link
Contributor

Makes even more sense now that we're storing all examples here instead of on a different repository. Feel free to revert if not needed. Thanks!

@ntotten
Copy link
Contributor

ntotten commented Apr 12, 2016

We are moving the examples out soon, but I think either way it is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants