Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-4548] Support optional responses #928

Merged
merged 4 commits into from
Sep 11, 2023
Merged

[SDK-4548] Support optional responses #928

merged 4 commits into from
Sep 11, 2023

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Sep 8, 2023 •
edited

Changes

Add support for an endpoint that can return a 200 or a 204.

  • GET /guardian/factors/sms/templates 200,204
  • GET /jobs/{id}/errors 200,204

(also fixed the playground)

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner September 8, 2023 14:06
@adamjmcgrath adamjmcgrath changed the title support optional responses [SDK-4548] Support optional responses Sep 8, 2023
@adamjmcgrath adamjmcgrath reopened this Sep 8, 2023
@adamjmcgrath adamjmcgrath merged commit 2939c8c into beta Sep 11, 2023
6 checks passed
@adamjmcgrath adamjmcgrath deleted the optional-responses branch September 11, 2023 11:32
@adamjmcgrath adamjmcgrath mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamjmcgrath @frederikprijck