Added 'protocol' option to AuthenticationClient and ManagementClient, defaulting to 'https' #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaulting to 'https'. This makes it way easier to create local, mocked Auth0 services for integration and E2E testing purposes.
|
It would be fantastic if this PR were merged. Is it possible to rebase and get it ready? |
|
We don't want to support http in this case. Thanks for the PR 🎉 |
|
Is there a reason for the restriction? We have a valid use case for the feature; I'm curious why this can't be merged. |
|
We don't want to make the library work with http endpoints. We had a similar request here and closed because of the same reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it way easier to create local, mocked Auth0 services for integration and E2E testing purposes, especially regarding the creation (and maintenance) of self-signed server certificates