Skip to content

Commit

Permalink
Merge branch 'latest-joi' of https://github.com/dominykas/node-jsonwe…
Browse files Browse the repository at this point in the history 
…btoken into dominykas-latest-joi
  • Loading branch information
@jfromaniello
jfromaniello committed Dec 6, 2016
2 parents 2c54016 + 3febcc1 commit 99127ee
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
language: node_js
before_install: npm i -g npm@1.4.28
sudo: false
before_install: npm i -g npm
node_js:
- "7"
- "6"
- "5"
- "4"
- "0.12"
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"url": "https://github.com/auth0/node-jsonwebtoken/issues"
},
"dependencies": {
"joi": "^6.10.1",
"joi": "^10.0.1",
"jws": "^3.1.4",
"lodash.once": "^4.0.0",
"ms": "^0.7.1",
Expand Down

3 comments on commit 99127ee

@kevin-frugier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfromaniello : may I ask why this branch was merged without considering the Travis failure?
As your build systems shows, it breaks ES5 compatibility : https://travis-ci.org/auth0/node-jsonwebtoken/builds/179471404
https://travis-ci.org/auth0/node-jsonwebtoken/jobs/179471407

const Hoek = require('hoek');
^^^^^
SyntaxError: Use of const in strict mode.

This makes it impossible to use jsonwebtoken (or any other package that depends on jsonwebtoken) in ES5 environments.

Going from 7.1.9 to 7.2.0 shouldn't break the ES5 compatibility, am I wrong?

Do you plan on fixing it?

@jfromaniello
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Sorry about that, reverting

@kevin-frugier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfromaniello : thank you for your reactivity! 👍

I having nothing against a leap in the ES6+ future at some point but not without a note in the release notes. 😉

Cheers!

Please sign in to comment.