Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of NPM package #347

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Reduce size of NPM package #347

merged 1 commit into from
Sep 6, 2017

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented May 4, 2017

This change removes the following files/directories:

  • .history
  • bin
  • test
  • .jshintrc
  • .npmignore
  • .travis.yml
  • CHANGELOG.md

The lib directory, decode.js, sign.js and verify.js are kept explicitly, README.md, package.json, LICENSE and index.js are kept implicitly.

If you want to keep some of the above files please let me know and I update the PR.

@purificant
Copy link

👍

@ziluvatar
Copy link
Contributor

Nice! LGTM.
Small comment, CHANGELOG is kept implicitly as well.
I'll mark it as next-major (although I hope no one was depending on the removed files by doing dark stuff). There are some PRs in the air waiting for next-major, I want to have this and them soon merged.

@jorrit
Copy link
Contributor Author

jorrit commented May 13, 2017

I never realized that the changelog was kept as well, thanks for pointing that out!

@rafaelrpinto
Copy link

If possible, please update the Joi dependency because they had this same issue.

The version that this module uses (6.10.1) has a package size of 703 kB and the current Joi version (10.6.0) has 166,9 kB.

@ziluvatar ziluvatar merged commit 0be5409 into auth0:master Sep 6, 2017
@jorrit jorrit deleted the patch-1 branch September 7, 2017 05:00
@jorrit
Copy link
Contributor Author

jorrit commented Sep 7, 2017

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants