Add tests for ES256 #360
Add tests for ES256 #360
Conversation
ziluvatar
force-pushed
the
add-ecdsa-tests
branch
from
d52cf0b
to
89900ea
Compare
| }); | ||
| }); | ||
|
|
||
| it('should be invalid', function (done) { |
There was a problem hiding this comment.
In the same describe when signing a token with expiration there is quite contradictory cases like should be valid and should be invalid. Also, the describe creates a token, which is used in some cases and overwritten in other cases. Either, make separate describe blocks for when expiration has gone out etc, or make the case-description clearer. And decide if the token variable is for the whole describe or make one per case :)
There was a problem hiding this comment.
TBH I didn't check the tests internally, I just wanted to run the same ones for ES256 as well.
If you feel I should refactor the tests before applying these changes let me know, I can prepare a PR to refactor them + renaming and a following one with the wrapping for ES256.
There was a problem hiding this comment.
Ok, with unaltered tests but applied to more areas than before, it's a step in a good direction. Let's put test refactoring to a future endeavor.
It reuses same tests we have for RS256, for ES256 in this case.
It only wraps the main
describeto run it once per asymmetric algorithm and replace'RS256'byalgorithmvariable. I didn't add/remove any test internally.I uploaded a x509 certificate as well, it is not used, but it can be useful in the future.
Closes #97