Fix breaking change on 7.4.2 for empty secret + "none" algorithm (sync code style) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziluvatar
changed the title
|
Thanks for this - I had explored this approach, but for some reason I thought it still failed due to the way JWS/JWA worked, looks like I was wrong! |
|
@rhysmccaig thank you for your fast PR!! (sorry for putting my suggestion on top of your code, but I worried you might have not noticed the comment and I didn't want to leave a breaking-change out there) You were right, I reopen the original issue, although now it has smaller scope. I think we need to fix jws to get rid of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR: #382
Fix: #381
It modifies @rhysmccaig approach to simply check the algorithm (
none?) before raising an error. I think modifying the secret is hacky.So this will reopen #286 for the case of callback-ish code style and algorithm
none(it didn't work before either). But it will solve the breaking change introduced by #374