-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow object for key signing #7
Conversation
This allows using passphrase protection for rsa keys
You've a typo in the verifier typeof check (On my phone, commenting on the line directly is hard) |
Thanks! I have a problem with the version of the crypto api... in node v10.39 the sign method expects a buffer or a string... but in node v0.11.8+ objects are allowed... |
Mind adding a Would either not run the password-protected PEM tests, or would assert that they throw 'Not a buffer' |
As of nodejs `v0.11.8`, SPKAC support was introduce. If your node | ||
version satisfies, then you can pass an object | ||
|
||
```javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Mind just making this inline with the sentence? It takes up quite a bit of visual space without providing a whole ton of value
On it |
@brianloveswords This LGTM. Would like to publish current master as a patch version before merging this as a minor. |
@brianloveswords FYI, I don't have npm access so I can't action the above |
@omsmith added you as co-owner of |
This allows using passphrase protection for rsa keys