Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow object for key signing #7

Merged
merged 4 commits into from
Jul 16, 2015
Merged

Allow object for key signing #7

merged 4 commits into from
Jul 16, 2015

Conversation

alexandrebodin
Copy link
Contributor

This allows using passphrase protection for rsa keys

This allows using passphrase protection for rsa keys
@omsmith
Copy link
Collaborator

omsmith commented Jul 3, 2015

You've a typo in the verifier typeof check

(On my phone, commenting on the line directly is hard)

@alexandrebodin
Copy link
Contributor Author

Thanks!

I have a problem with the version of the crypto api... in node v10.39 the sign method expects a buffer or a string... but in node v0.11.8+ objects are allowed...

@omsmith
Copy link
Collaborator

omsmith commented Jul 5, 2015

Mind adding a process.version check in the tests or somesuch, so that we can still run the tests in 0.10?

Would either not run the password-protected PEM tests, or would assert that they throw 'Not a buffer'

As of nodejs `v0.11.8`, SPKAC support was introduce. If your node
version satisfies, then you can pass an object

```javascript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) Mind just making this inline with the sentence? It takes up quite a bit of visual space without providing a whole ton of value

@alexandrebodin
Copy link
Contributor Author

On it

@omsmith
Copy link
Collaborator

omsmith commented Jul 5, 2015

@brianloveswords This LGTM. Would like to publish current master as a patch version before merging this as a minor.

@omsmith
Copy link
Collaborator

omsmith commented Jul 15, 2015

@brianloveswords FYI, I don't have npm access so I can't action the above

@brianloveswords
Copy link
Collaborator

@omsmith added you as co-owner of jws and jwa !

omsmith added a commit that referenced this pull request Jul 16, 2015
Allow object for key signing
@omsmith omsmith merged commit fac51ae into auth0:master Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants