Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import default Axios instance. fix #215. #216

Merged
merged 1 commit into from Feb 23, 2021

Conversation

dsebastien
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

I've changed the request wrapper to use the (apparently) idiomatic way to import/use Axios. This should normally fix #215.

References

Include any links supporting this change such as a:

Testing

Configure the library to load a JWKS file and check that it works as expected.
Add nano (which has side-effects as it adds/configures axios-cookiejar-support) to the test project and check that it still works as expected.

Checklist

  • [ N/A ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • [ not sure ] All active GitHub checks for tests, formatting, and security are passing
  • [ note sure ] The correct base branch is being used, if not master

@dsebastien dsebastien requested a review from a team as a code owner February 10, 2021 11:32
@davidpatrick davidpatrick changed the base branch from master to 1.x.x February 23, 2021 21:42
@davidpatrick davidpatrick merged commit 4679199 into auth0:1.x.x Feb 23, 2021
@davidpatrick davidpatrick added this to the 1.x.x milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios cookiejar support error
2 participants