Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interceptor bind client #237

Merged
merged 2 commits into from Mar 23, 2021
Merged

Interceptor bind client #237

merged 2 commits into from Mar 23, 2021

Conversation

erikfried
Copy link
Contributor

Description

the client was not bound to getSigningKey in interceptor.js, making this undefined in the JwksClient instance.
This was causing a TypeErrorwhen the interceptor would not return a key.

     TypeError: Cannot read property 'logger' of undefined
      at getSigningKey (src/JwksClient.js:71:10)
      at JwksClient.<anonymous> (src/wrappers/interceptor.js:26:12)
      at async Context.<anonymous> (tests/interceptor.tests.js:39:19)

References

Testing

Unit tests added to reproduce the error, and verify the fix.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@erikfried erikfried requested a review from a team as a code owner March 23, 2021 13:19
@davidpatrick
Copy link
Contributor

Thanks @erikfried

@davidpatrick davidpatrick merged commit dd3a05c into auth0:master Mar 23, 2021
@davidpatrick davidpatrick added this to the vNext2 milestone Mar 23, 2021
@davidpatrick davidpatrick mentioned this pull request Mar 24, 2021
@davidpatrick davidpatrick mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants