Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definitions depend on jsonwebtoken #314

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Type definitions depend on jsonwebtoken #314

merged 1 commit into from
Jun 7, 2022

Conversation

adamjmcgrath
Copy link
Contributor

Description

The ts def file depends on jsonwebtoken so the type deps should be included in the dependencies (like express)

References

fixes #312

@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Jun 7, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner June 7, 2022 14:30
@adamjmcgrath adamjmcgrath merged commit 995dbdb into master Jun 7, 2022
@adamjmcgrath adamjmcgrath deleted the jsonwebtoken-dep branch June 7, 2022 16:27
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript compilation fails on v2.1.1+ due to missing jsonwebtoken types
2 participants
@adamjmcgrath @Widcket