Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating base64url to v2.0.0 #58

Merged
merged 2 commits into from
Sep 5, 2016
Merged

Updating base64url to v2.0.0 #58

merged 2 commits into from
Sep 5, 2016

Conversation

MarkHerhold
Copy link
Contributor

The base64url module changes from 1.x to 2.x only involved a rewrite to TypeScript. It appears that no tests were changed between the versions. Fixes issue #56

@omsmith
Copy link
Collaborator

omsmith commented Sep 5, 2016

Make it a ^ and you've got yourself a deal

@MarkHerhold
Copy link
Contributor Author

@omsmith Good to go so long as you squash and merge. :) Thanks!

@omsmith omsmith merged commit c2f94b0 into auth0:master Sep 5, 2016
@MarkHerhold
Copy link
Contributor Author

@omsmith Thanks! Looking forward to a release. :)
Also, #56 can now be closed.

@daKuleMune
Copy link

daKuleMune commented Nov 1, 2016

I noted that this change has not yet been reflected in the npm package. Can you verify if this will fix the deprecation warning in node 7?
DeprecationWarning: Using Buffer without 'new' will soon stop working. Use 'new Buffer()', or preferably 'Buffer.from()', 'Buffer.allocUnsafe()' or 'Buffer.alloc()' instead. at Buffer (buffer.js:79:13) at base64url (/project/node_modules/base64url/index.js:41:21) at jwsSecuredInput (/project/node_modules/jws/lib/sign-stream.js:11:23) ... etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants