-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Fix dependency security issues #114
Conversation
update saml, express, istanbul and mocha add standard-version for release tooling refactor server.js to work with newer express
# Conflicts: # package.json
# Conflicts: # .travis.yml # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ideally the CHANGELOG.md
would be updated after merging into master
and when making the first release from there.
I can see major upgrades on Could you mention what were the breaking changes in those libs? Would they affect the consumers of this library in any way (just in case we need to modify README with migration steps or similar) |
Description
BREAKING CHANGE: This removes support for node versions 4, 6 & 8 - newer versions of mocha use async/await, causing tests to fail in older versions.
References
Addressing Issues:
#106
#107
Addressing issues resolved in other PRs:
#109
Testing
No functional changes introduced
Checklist
master