Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sinon is a dev dependency #71

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

FauxFaux
Copy link
Contributor

@FauxFaux FauxFaux commented May 6, 2020

Description

sinon, a mocking framework used in tests, is listed as a production dependency. sinon is bigger than all of the rest of the code and tests and dependencies combined, so it's a shame shipping it as a production dependency.

Change it to a dev dependency, only available for tests.

Testing

faux@astoria:~/clone/node-xml-encryption% g grep sinon | fgrep -v package-lock
package.json:    "sinon": "^9.0.2"
test/xmlenc.encryptedkey.js:var sinon = require('sinon');
test/xmlenc.encryptedkey.js:    consoleSpy = sinon.spy(console, 'warn');

@FauxFaux FauxFaux requested a review from a team as a code owner May 6, 2020 20:38
gkwang
gkwang previously approved these changes May 6, 2020
Copy link
Contributor

@gkwang gkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It was added to prod dependency by mistake.

@gkwang
Copy link
Contributor

gkwang commented May 6, 2020

@FauxFaux Can you kindly sign the commit since it's required for us to merge the change.

@FauxFaux
Copy link
Contributor Author

FauxFaux commented May 6, 2020

Third time lucky!

@gkwang gkwang added this to the v1.2.0 milestone May 6, 2020
@gkwang gkwang merged commit b5a912b into auth0:master May 6, 2020
@FauxFaux FauxFaux deleted the feat/dev-sinon branch May 6, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants