Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken podspec for Cocoapods installations #136

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

danieljvdm
Copy link
Contributor

@danieljvdm danieljvdm commented Mar 7, 2018

The current podspec is invalid and will cause errors in pod install. This update fixes these issues and adds better version control that is tied to the npm version.

@LcTwisk
Copy link

LcTwisk commented Mar 22, 2018

Can we merge this 😋?

@lbalmaceda
Copy link
Contributor

@cocojoe can you review this one please?

@cocojoe
Copy link
Member

cocojoe commented Mar 26, 2018

I don't believe it was intended to be used as a pod, it's not something listed in the installation. It's never been published, just looks like a place holder podfile.
The method of installation is via npm.

What are you doing with it?

@LcTwisk
Copy link

LcTwisk commented Mar 26, 2018

@cocojoe What is the reason of having a .podspec if there is no intention to use it with Cocoapods 😜? Most RN libraries support Cocoapods nowadays (even through react-native link). Probably because linking static libraries can result in conflicting dependencies while Cocoapods is able to resolve them.

Btw, npm and pods go perfectly together. This is how I'm using the Auth0 library with the proposed changes in this PR:
pod 'A0Auth0', :path => '../node_modules/react-native-auth0'

@cocojoe
Copy link
Member

cocojoe commented Mar 26, 2018

If this is just used internally then maybe yes, no harm.

@danieljvdm
Copy link
Contributor Author

@cocojoe you don't have to publish for it to work on Cocoapods. Cocoapods is the industry standard in iOS development, and most people who are working on serious, large projects are going to be using Cocoapods. It's a pretty serious limitation not to support it. At the very least, you can support it unofficially by just merging this PR. There already is a podspec that is completely broken, why not fix it?

@danieljvdm
Copy link
Contributor Author

Furthermore, I couldn't even get this library to work without having to fork this repo. If you're running an iOS setup with React Native installed via Cocoapods, the search headers will be completely wrong and this project won't be able to find and use the React framework.

@cocojoe cocojoe self-requested a review April 2, 2018 20:17
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not published, expands usage. LGTM

@cocojoe cocojoe merged commit fff6acf into auth0:master Apr 2, 2018
@danieljvdm
Copy link
Contributor Author

@cocojoe thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants