Update Minimum iOS Deployment Target, inline with React Libs #176
Conversation
|
Thanks for the PR. Where does it say 9.0 is the minimum? You can still select 8.0 in Xcode 10. I mean I think 9.0 or even 10.0 is a sensible minimum these days. |
|
I'll need to test this, will set some time aside tomorrow and run the whole thing through latest RN. |
|
Updated to 8.0, I did find that works as expected. |
|
Had a look at this, so I saw the Warning. Having taken a look at the other Libs, given that all of the React* libs have a minimum deployment target of 9.0. It makes sense for us to follow this. |
| @@ -152,7 +152,7 @@ | |||
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 7.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
There was a problem hiding this comment.
9.0 Is better as it aligns with the minimum versions of the React* Libs
| @@ -186,7 +186,7 @@ | |||
| GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
| GCC_WARN_UNUSED_FUNCTION = YES; | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 7.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
There was a problem hiding this comment.
9.0 Is better as it aligns with the minimum versions of the React* Libs
cocojoe
changed the title
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
@cocojoe updated to 9.0 and removed IDE file. |
|
Fixes #179 |
Updated Xcode build version from 7.0 to 9.0 to build for iOS 12.