Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podspec restore react dependency #214

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Podspec restore react dependency #214

merged 1 commit into from
Apr 18, 2019

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Apr 16, 2019

Changes

Restore the react dependency in Podspec
Fixes #207

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

s.author = { "auth0" => "oss@auth0.com" }
s.platform = :ios, "7.0"
s.author = { "auth0" => "oss@auth0.com" }
s.platform = :ios, "9.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Native itself is minimum iOS 9

@cocojoe cocojoe requested a review from lbalmaceda April 17, 2019 09:43
@cocojoe cocojoe added this to the v1-Next milestone Apr 17, 2019
@cocojoe cocojoe merged commit 4ef20b3 into master Apr 18, 2019
@cocojoe cocojoe mentioned this pull request Apr 18, 2019
@cocojoe cocojoe deleted the fixed-podspec branch April 18, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React/RCTDefines.h file not found
2 participants