Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when bundle identifier contains uppercase characters #316

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

lbalmaceda
Copy link
Contributor

Changes

In order to improve DX when the Application ID (android) or Bundle Identifier (iOS) values have uppercase characters, a warning will be printed to the device console. This warning only appears on the non-production environment according to the react-native docs.

This is just a warning! The authorize call will go through regardless of the bundle identifier value.

The warning message is the following:

"The Bundle Identifier or Application ID of your app contains uppercase characters and will be lowercased to build the Callback URL. Check the Auth0 dashboard to whitelist the right URL value."

This PR also rephrases the callback URLs section of the README. (feedback?)

References

React native docs about warnings https://reactnative.dev/docs/debugging#warnings
Resolves #130

Testing

No unit tests, only manual.

image

image

image

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda requested a review from a team June 8, 2020 23:27
@lbalmaceda lbalmaceda added the small This PR may require low effort to action, or contains few changes to review label Jun 8, 2020
@lbalmaceda lbalmaceda merged commit 3dbc6ee into master Jun 9, 2020
@lbalmaceda lbalmaceda deleted the warn-schema branch June 9, 2020 15:38
@lbalmaceda lbalmaceda modified the milestones: v2-Next, v2.5.0 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Redirect from browser after web auth doesn't happen
2 participants