Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the www-authenticate header parsing logic #329

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Conversation

lbalmaceda
Copy link
Contributor

Changes

The header object is a special list that must be accessed with get(name), otherwise, there are certain cors scenarios where not all the headers would be exposed.

This PR handles the possibility of that header not being set and ensures the last fallback is also test-covered.

References

#285 introduced a change that wasn't properly tested

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added CH: Fixed small This PR may require low effort to action, or contains few changes to review labels Aug 10, 2020
@lbalmaceda lbalmaceda added this to the v2-Next milestone Aug 10, 2020
@lbalmaceda lbalmaceda requested a review from a team August 10, 2020 23:11
@nicosabena
Copy link

Awesome, thanks Luciano!

@lbalmaceda lbalmaceda merged commit dd4c5ae into master Aug 12, 2020
@lbalmaceda lbalmaceda deleted the fix-header-parsing branch August 12, 2020 00:11
@lbalmaceda lbalmaceda modified the milestones: v2-Next, v2.5.1 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants