Added tokenType to credentials returned in Android #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Apr 26, 2023
| @@ -29,7 +29,8 @@ public static ReadableMap toMap(Credentials credentials) { | |||
| map.putString(ID_TOKEN_KEY, credentials.getIdToken()); | |||
| map.putString(SCOPE, credentials.getScope()); | |||
| map.putString(REFRESH_TOKEN_KEY, credentials.getRefreshToken()); | |||
| map.putString(TYPE_KEY, credentials.getType()); | |||
| map.putString(TYPE_KEY, credentials.getType());//@deprecate This should be removed in next major (Reference - https://github.com/auth0/react-native-auth0/issues/614) | |||
| map.putString(TOKEN_TYPE_KEY, credentials.getType()); | |||
| return map; | |||
There was a problem hiding this comment.
Should we be updating any tests?
There was a problem hiding this comment.
Since this is android specific and we don't have native unit tests, no unit tests need to be updated
Widcket
approved these changes
Apr 26, 2023
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Android has been returning
typein Credentials object instead oftokenTypeso we are adding this. We will be removingtypein a major release as it could be a breaking change if we remove it nowReferences
#614
Testing