-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3870] Typescript Migration #628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on migrating this to TypeScript 🚀
I left a couple of comments, but in general I think it's useful to revisit the amount of any
's being used. There are situations where I think it's okay to keep any, but quite a bit (especially when it comes to option parameters) should probably better be typed.
Some any's could also be unknown
, which in that case might something we want to consider using (I added a comment for an example on where I think it should be possible to use unknown).
Co-authored-by: Frederik Prijck <frederik.prijck@gmail.com>
@frederikprijck I have improved the amount of any used now. Above all now our authentication client methods will have type support. I have also implemented all the comments you have added. Thanks for the feedback 🙇 Do check this out when you have time |
Co-authored-by: Frederik Prijck <frederik.prijck@gmail.com>
Co-authored-by: Frederik Prijck <frederik.prijck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, but I believe there are still some fundamental issues in ensuring TypeScript is useful here.
Changes
We are migrating to Typescript to provide better developer experience. Things to consider in this PR are
webauth
can be reviewed a little leniently as we will move it to native code in the current initiativeTesting