Added clearSession iOS Safari Method #65
Conversation
|
Also ran it through Xcode/Re-Indent 😄 |
|
Note: Sample PR auth0-samples/auth0-react-native-sample#4 |
webauth/index.js
Outdated
| clearSession(options = {}, callback) { | ||
| const { clientId, domain, client, agent } = this; | ||
| const federated = options.federated || false; | ||
| A0Auth0.clearSession(domain, federated, callback); |
There was a problem hiding this comment.
Since this method is not yet available on android lets fail when the OS is not iOS.
There was a problem hiding this comment.
webauth/index.js
Outdated
| * | ||
| * @memberof WebAuth | ||
| */ | ||
| clearSession(options = {}, callback) { |
There was a problem hiding this comment.
The library uses promises instead of callbacks
Added clearSession JS wrapper
Added iOS platform check to method
cocojoe
force-pushed
the
added-clearsession-safari
branch
from
5fb74c3
to
4c6cb1a
Compare
|
Ping |
ios/A0Auth0.m
Outdated
| self.sessionCallback = callback; | ||
| } | ||
|
|
||
| RCT_EXPORT_METHOD(clearSession:(NSString *)domain federated:(BOOL)federated callback:(RCTResponseSenderBlock)callback) { | ||
| NSString *urlString = [NSString stringWithFormat:@"https://%@/v2/logout", domain]; |
There was a problem hiding this comment.
Lets use NSURLComponents to build urls
There was a problem hiding this comment.
And TBH I'd rather build the full url in JS and make this method a more generic one like show and close on load thing
ios/A0Auth0.m
Outdated
| [self terminateWithError:error dismissing:NO animated:NO]; | ||
| } | ||
|
|
||
| - (void)safariViewController:(SFSafariViewController *)controller didCompleteInitialLoad:(BOOL)didLoadSuccessfully { | ||
| if (!didLoadSuccessfully) { | ||
| if (self.didLoadCallback) { | ||
| didLoadSuccessfully ? self.didLoadCallback(@[[NSNull null]]) : self.didLoadCallback(@[@{@"error": @"failed to load"}]); |
There was a problem hiding this comment.
Probably cleaner to do the ternary operator with the parameter and the call the callback later
ios/A0Auth0.m
Outdated
| }; | ||
| @"error": @"a0.session.failed_load", | ||
| @"error_description": @"Failed to load authorize url" | ||
| }; | ||
| [self terminateWithError:error dismissing:YES animated:YES]; |
There was a problem hiding this comment.
We need to clean the didLoadCallback too
There was a problem hiding this comment.
What are you thinking here, refactor it all to use the didLoadCallback and make the auto close optional?
There was a problem hiding this comment.
Ignore that, out of scope of this PR.
webauth/index.js
Outdated
| return new Promise(function (resolve, reject) { | ||
| if (Platform.OS !== 'ios') { reject(new Error('clearSession only supported in iOS')); } | ||
| A0Auth0.clearSession(domain, federated, function (err, data) { | ||
| if (err !== null) return reject(err); |
Move URL builder to JS Tidy up code
Improve error message and use AuthError type
Make use of Auth client url builder. Make iOS implementation reuse existing handlers
hzalaz
force-pushed
the
added-clearsession-safari
branch
from
7f0edb0
to
493ed73
Compare
Added clearSession JS wrapper