Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export types as part of root #676

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Export types as part of root #676

merged 2 commits into from
Jul 11, 2023

Conversation

poovamraj
Copy link
Contributor

Changes

  • We are exporting all the external types through root now.
  • Typescript currently packages some of the unwanted files in the package. Previous exclude didn't work as tsconfig.build.json overrides it
  • The path refers to root package

References

#675

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

@poovamraj poovamraj requested a review from a team as a code owner July 11, 2023 12:34
@poovamraj poovamraj changed the base branch from beta-development to vnext July 11, 2023 12:44
@poovamraj poovamraj merged commit e266aba into vnext Jul 11, 2023
4 checks passed
@poovamraj poovamraj deleted the export-types branch July 11, 2023 12:53
@poovamraj poovamraj mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poovamraj @Widcket