Close Browser app tab after finishing Auth #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbalmaceda can you take a look at this first please. |
|
Seems fine. You should also try it without Chrome so it opens the link in a Browser instead of a Custom Tab. Btw, we don't have tests for this? |
|
I tried in browser, didn't work in the one I tested. RNA has tests but the platform specific stuff doesn't. Probably a bit of work to setup a CI that is testing JS/Android/iOS. |
|
I'd not do native tests to keep this simple. The native code should be minimal |
hzalaz
changed the title
hzalaz
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in Chrome 61
#87