Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #15

Closed
dentarg opened this issue Mar 12, 2015 · 6 comments
Closed

Integration tests #15

dentarg opened this issue Mar 12, 2015 · 6 comments

Comments

@dentarg
Copy link
Contributor

dentarg commented Mar 12, 2015

Dedicate an auth0 account for tests, keys can be encrypted in .travis.yml, write tests that actually do stuff with the API.

What do you think?

@jfromaniello
Copy link
Member

Yes, it make sense @hzalaz will look into this.. thank for all your feedback

@dentarg
Copy link
Contributor Author

dentarg commented Apr 16, 2015

@hzalaz I noticed 6e19b8f

When 2 builds run in parallel, they clash with each other.

I think the answer is https://github.com/vcr/vcr

GitHub uses it for their API client, you can read about it at https://github.com/octokit/octokit.rb#running-and-writing-new-tests

@dentarg
Copy link
Contributor Author

dentarg commented Apr 16, 2015

I think the answer is https://github.com/vcr/vcr

...not to remove number of Ruby versions to test against

@hzalaz
Copy link
Member

hzalaz commented Apr 16, 2015

I know about vcr but in my experience the recorded tests will get outdated easily and everything will seem ok when it shouldn't, that's the reason I'd rather hit the API directly for integration tests. Also we're already mocking http in unit tests (I'd rather use them there) so both test will be exactly the same.

I want to rework the "new tests" to avoid clashing with each other (like prefixing ids) but until then I prefer a reliable build.

@dentarg
Copy link
Contributor Author

dentarg commented Apr 16, 2015

I understand. Nice work on this!

@hzalaz
Copy link
Member

hzalaz commented Apr 16, 2015

We don't have all endpoints tested against the real API but at least we have most of /users which should be the most used. We'll continue to add more endpoints eventually. PR are welcome! 😄

@ntotten ntotten closed this as completed Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants