Add VCR to and improve all integration tests #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Oct 4, 2018
| @@ -2,22 +2,28 @@ module Credentials | |||
| module_function | |||
There was a problem hiding this comment.
Whitespace only in this file
joshcanhelp
commented
Oct 5, 2018
| @@ -32,7 +32,7 @@ def resource_server(resource_server_id) | |||
| # @return [json] Returns the resource server. | |||
| def create_resource_server(identifier, options = {}) | |||
| raise Auth0::InvalidParameter, 'Must supply a valid resource server id' if identifier.to_s.empty? | |||
| if ['<', '>'].include?(options.fetch(:name, '')) | |||
| if options.fetch(:name, '').index(/[<>]/) | |||
There was a problem hiding this comment.
Was not actually checking for what it was trying to check for
joshcanhelp
commented
Oct 5, 2018
| @@ -101,7 +101,7 @@ def delete_user(user_id) | |||
| # @return [json] Returns the updated user. | |||
| def patch_user(user_id, body) | |||
| raise Auth0::MissingUserId, 'Must supply a valid user_id' if user_id.to_s.empty? | |||
| raise Auth0::InvalidParameter, 'Must supply a valid body' if body.to_s.empty? | |||
| raise Auth0::InvalidParameter, 'Must supply a valid body' if body.to_s.empty? || body.empty? | |||
There was a problem hiding this comment.
Did not catch an empty hash
joshcanhelp
commented
Oct 5, 2018
| @@ -13,26 +13,6 @@ | |||
| config.filter_run focus: true | |||
| config.run_all_when_everything_filtered = true | |||
| config.include Credentials | |||
| config.after(:suite) do | |||
There was a problem hiding this comment.
Removed unnecessary cleanup
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
add-vcr-to-integration-tests
branch
from
000e2cc
to
a05c6bc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VCR HTTP recording to integration test suite. Specifically:
after(:suite)