Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exclude_fields parameter for getting users #34

Merged
merged 1 commit into from
Jun 1, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/auth0/api/v2/users.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ module V2
#https://auth0.com/docs/apiv2#!/users
module Users
#https://auth0.com/docs/apiv2#!/users/get_users
def users( per_page: nil, page: nil, include_totals: nil, sort: nil, connection: nil, fields: nil, exclude_fields: nil, q: nil )
def users( per_page: nil, page: nil, include_totals: nil, sort: nil, connection: nil, fields: nil, q: nil )
request_params = {
per_page: per_page,
page: page,
include_totals: include_totals,
sort: sort,
connection: connection,
fields: fields,
exclude_fields: exclude_fields,
q: q
}
path = "/api/v2/users"
Expand All @@ -35,11 +34,10 @@ def delete_users
end

#https://auth0.com/docs/apiv2#!/users/get_users_by_id
def user(user_id, fields: nil, exclude_fields: nil)
def user(user_id, fields: nil)
path = "/api/v2/users/" + user_id.to_s
request_params = {
fields: fields,
exclude_fields: exclude_fields
}
get(path, request_params)
end
Expand Down
4 changes: 2 additions & 2 deletions spec/integration/lib/auth0/api/v2/api_users_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
context "#filters" do
it { expect(client.users(per_page: 1).size).to be 1 }
it { expect(client.users(per_page: 1, fields: [:picture, :email, :user_id].join(',')).first).to include("email", "user_id", "picture") }
it { expect(client.users(per_page: 1, fields: [:picture, :email, :user_id].join(','), exclude_fields: true).first).to_not include("email", "user_id", "picture") }
it { expect(client.users(per_page: 1, fields: [:email].join(',')).first).to_not include("user_id", "picture") }
end

end
Expand All @@ -37,7 +37,7 @@

context "#filters" do
it { expect(client.user(user["user_id"], fields: [:picture, :email, :user_id].join(','))).to include("email", "user_id", "picture") }
it { expect(client.user(user["user_id"], fields: [:picture, :email, :user_id].join(','), exclude_fields: true)).to_not include("email", "user_id", "picture") }
it { expect(client.user(user["user_id"], fields: [:email].join(','))).to_not include("user_id", "picture") }
end

end
Expand Down
4 changes: 2 additions & 2 deletions spec/lib/auth0/api/v2/users_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
it {expect(@instance).to respond_to(:users)}
it {expect(@instance).to respond_to(:get_users)}
it "is expected to call /api/v2/users" do
expect(@instance).to receive(:get).with("/api/v2/users",{:per_page=>nil, :page=>nil, :include_totals=>nil, :sort=>nil, :connection=>nil, :fields=>nil, :exclude_fields=>nil, :q=>nil})
expect(@instance).to receive(:get).with("/api/v2/users",{:per_page=>nil, :page=>nil, :include_totals=>nil, :sort=>nil, :connection=>nil, :fields=>nil, :q=>nil})
expect{@instance.users}.not_to raise_error
end
end

context ".user" do
it {expect(@instance).to respond_to(:user)}
it "is expected to call get request to /api/v2/users/USER_ID" do
expect(@instance).to receive(:get).with("/api/v2/users/USER_ID", {fields: nil, exclude_fields: nil})
expect(@instance).to receive(:get).with("/api/v2/users/USER_ID", {fields: nil})
expect{@instance.user("USER_ID")}.not_to raise_error
end
end
Expand Down