Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-429: auth0_resource_server_scope resource #589

Merged
merged 18 commits into from May 23, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented May 19, 2023

🔧 Changes

Introducing the auth0_resource_server_scope resource which enables the management of resource server scopes through a 1-1 relationship. This PR follows a line of similar PRs which separate inter-resource relationships into their own dedicated resources to enable more modular Terraform composition.

📚 References

Similar Resources:

🔬 Testing

Added suite of integration tests.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner May 19, 2023 17:53
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #589 (268eabf) into main (7f2eecc) will decrease coverage by 0.34%.
The diff coverage is 65.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   86.86%   86.53%   -0.34%     
==========================================
  Files          71       72       +1     
  Lines       11148    11320     +172     
==========================================
+ Hits         9684     9796     +112     
- Misses       1116     1168      +52     
- Partials      348      356       +8     
Impacted Files Coverage Δ
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/resourceserver/resource_scope.go 63.63% <63.63%> (ø)
internal/auth0/resourceserver/resource.go 84.89% <100.00%> (+0.57%) ⬆️

docs/resources/resource_server_scope.md Show resolved Hide resolved
docs/resources/resource_server_scope.md Outdated Show resolved Hide resolved
docs/resources/resource_server_scope.md Outdated Show resolved Hide resolved
docs/resources/resource_server_scope.md Show resolved Hide resolved
internal/auth0/resourceserver/resource.go Show resolved Hide resolved
internal/auth0/resourceserver/resource_scope.go Outdated Show resolved Hide resolved
internal/auth0/resourceserver/resource_scope.go Outdated Show resolved Hide resolved
internal/auth0/resourceserver/resource_scope.go Outdated Show resolved Hide resolved
@willvedd willvedd requested a review from sergiught May 22, 2023 22:19
@willvedd willvedd merged commit c5f5cef into main May 23, 2023
4 checks passed
@willvedd willvedd deleted the DXCDT-429-resource-server-scope-resource branch May 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants