DXCDT-308: Add guide on how to achieve 0 downtime client credential rotation #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
guide/0-downtime
branch
from
78c7f47
to
8d147ad
Compare
|
The content is good but how will it be discovered? It needs to have some inbound links so that people can find this content. IMO it makes sense for it to be mentioned in the client docs and in the readme. |
sergiught
force-pushed
the
guide/0-downtime
branch
from
8d147ad
to
f3ca52e
Compare
|
Good point, please check |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 71 71
Lines 11148 11154 +6
=======================================
+ Hits 9684 9690 +6
Misses 1116 1116
Partials 348 348
|
willvedd
reviewed
May 22, 2023
willvedd
reviewed
May 22, 2023
willvedd
reviewed
May 22, 2023
willvedd
reviewed
May 22, 2023
willvedd
reviewed
May 22, 2023
sergiught
force-pushed
the
guide/0-downtime
branch
from
ccf9865
to
362b50a
Compare
willvedd
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敡 Changes
馃摎 References
馃敩 Testing
馃摑 Checklist