Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-450: Remove deprecated tenant pages #711

Merged
merged 3 commits into from Jul 13, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 12, 2023

🔧 Changes

Management of the error, guardian MFA and change password page templates via the auth0_tenant resource has been deprecated in favor of the auth0_pages resource. This PR removes the code associated with this deprecation.

📚 References

🔬 Testing

N/A.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner July 12, 2023 20:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #711 (fe76288) into v1 (408384e) will decrease coverage by 0.11%.
The diff coverage is 83.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #711      +/-   ##
==========================================
- Coverage   87.60%   87.50%   -0.11%     
==========================================
  Files          85       85              
  Lines       13484    13392      -92     
==========================================
- Hits        11813    11718      -95     
- Misses       1264     1266       +2     
- Partials      407      408       +1     
Impacted Files Coverage Δ
internal/auth0/tenant/expand.go 100.00% <ø> (ø)
internal/auth0/tenant/flatten.go 88.23% <ø> (+7.22%) ⬆️
internal/auth0/tenant/resource.go 97.09% <ø> (-0.60%) ⬇️
internal/auth0/page/flatten.go 74.28% <67.85%> (-25.72%) ⬇️
internal/auth0/page/expand.go 90.47% <92.50%> (+2.01%) ⬆️
internal/auth0/page/resource.go 82.72% <100.00%> (ø)

@sergiught sergiught merged commit c5494ad into v1 Jul 13, 2023
6 checks passed
@sergiught sergiught deleted the DXCDT-450-remove-deprecated-tenant-fields branch July 13, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants