Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-450: Remove client deprecated fields #725

Merged
merged 10 commits into from Jul 16, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 14, 2023

🔧 Changes

Ahead of our upcoming major release, this PR removing the deprecated client_secret and token_endpoint_auth_method properties from the auth0_client resource and put on the correlating data source instead.

📚 References

Migration Guide

🔬 Testing

Some tests changes to test new behavior changes and non-behavioral test changes to remove deprecated components.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd marked this pull request as ready for review July 14, 2023 15:06
@willvedd willvedd requested a review from a team as a code owner July 14, 2023 15:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #725 (58b06f9) into v1 (5499aab) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #725      +/-   ##
==========================================
- Coverage   87.54%   87.49%   -0.05%     
==========================================
  Files          87       87              
  Lines       13244    13235       -9     
==========================================
- Hits        11594    11580      -14     
- Misses       1247     1251       +4     
- Partials      403      404       +1     
Impacted Files Coverage Δ
internal/auth0/client/expand.go 87.84% <ø> (-0.02%) ⬇️
internal/auth0/client/data_source.go 85.91% <100.00%> (+5.52%) ⬆️
internal/auth0/client/flatten.go 85.20% <100.00%> (+1.70%) ⬆️
internal/auth0/client/resource.go 98.71% <100.00%> (-0.43%) ⬇️

@willvedd willvedd enabled auto-merge (squash) July 14, 2023 17:06
@willvedd willvedd merged commit 3525cea into v1 Jul 16, 2023
6 checks passed
@willvedd willvedd deleted the DXCDT-450-remove-client-deprecated-fields branch July 16, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants