Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-460: Refactor how we check for 404 errors #727

Merged
merged 2 commits into from Jul 18, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jul 16, 2023

🔧 Changes

In this PR we're refactoring how we do the 404 checks and triggering a resource deletion. We're now consistently doing that in the read, update and delete funcs, but the create should continue to raise the error to let the user know something went wrong during creation.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #727 (ec4924c) into v1 (ec4924c) will not change coverage.
The diff coverage is n/a.

❗ Current head ec4924c differs from pull request most recent head c4cf094. Consider uploading reports for the commit c4cf094 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #727   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          87       87           
  Lines       13237    13237           
=======================================
  Hits        11586    11586           
  Misses       1248     1248           
  Partials      403      403           

@sergiught sergiught force-pushed the patch/DXCDT-460-errors-404 branch 3 times, most recently from 2de9dfd to 4ce35dc Compare July 16, 2023 14:13
@sergiught sergiught changed the base branch from v1 to patch/node-version July 16, 2023 14:13
@sergiught sergiught marked this pull request as ready for review July 17, 2023 07:44
@sergiught sergiught requested a review from a team as a code owner July 17, 2023 07:44
@sergiught
Copy link
Contributor Author

Codecov is hiding the glorious fact that this takes our coverage to 89.74% https://app.codecov.io/gh/auth0/terraform-provider-auth0/tree/patch%2FDXCDT-460-errors-404

Base automatically changed from patch/node-version to v1 July 18, 2023 15:13
@sergiught sergiught merged commit 1150d60 into v1 Jul 18, 2023
6 checks passed
@sergiught sergiught deleted the patch/DXCDT-460-errors-404 branch July 18, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants