Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESD-30646: Add validation to prevent empty string scopes in client grant resource #793

Merged
merged 1 commit into from Aug 25, 2023

Conversation

sergiught
Copy link
Contributor

馃敡 Changes

Prevent empty string values within scopes attribute of auth0_client_grant resource, so we avoid ending up with a panic.

馃摎 References

馃敩 Testing

馃摑 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught marked this pull request as ready for review August 25, 2023 13:32
@sergiught sergiught requested a review from a team as a code owner August 25, 2023 13:32
@codecov-commenter
Copy link

Codecov Report

Merging #793 (1b5aac2) into v1 (cf36419) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #793   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files          99       99           
  Lines       13188    13189    +1     
=======================================
+ Hits        11927    11928    +1     
  Misses        893      893           
  Partials      368      368           
Files Changed Coverage 螖
internal/auth0/client/resource_grant.go 82.75% <100.00%> (+0.20%) 猬嗭笍

@sergiught sergiught merged commit 5ddb3c0 into v1 Aug 25, 2023
6 checks passed
@sergiught sergiught deleted the ESD-30646-client-grant branch August 25, 2023 13:44
@tyfrth
Copy link

tyfrth commented Nov 23, 2023

Hey @sergiught and @willvedd! Stumbled on this by way of a community topic - It looks like it is possible to create a client grant with with an empty array for the scope param using the management API directly. Judging by the ESD, it's not possible to mirror that behavior here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants