DXCDT-518: Stop requiring read:client_keys permission for reading the auth0_client_credentials resource
#795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Aug 25, 2023
| data.Id(), | ||
| management.IncludeFields( | ||
| "client_id", | ||
| "client_secret", |
There was a problem hiding this comment.
By explicitly requiring the client_secret to be within the response, we were implying a requirement on the read:client_keys permission.
6 tasks
willvedd
approved these changes
Aug 25, 2023
Widcket
approved these changes
Aug 25, 2023
sergiught
force-pushed
the
DXCDT-518-client-secret
branch
from
89e50ac
to
bbc0dd9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #795 +/- ##
==========================================
+ Coverage 90.50% 90.54% +0.03%
==========================================
Files 99 99
Lines 13265 13256 -9
==========================================
- Hits 12005 12002 -3
+ Misses 893 889 -4
+ Partials 367 365 -2
|
sergiught
force-pushed
the
DXCDT-518-client-secret
branch
from
bbc0dd9
to
f4fe114
Compare
sergiught
force-pushed
the
DXCDT-518-client-secret
branch
from
f4fe114
to
4bc3172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR stops requiring the
read:client_keyspermission for reading theauth0_client_credentialsresource by removing the include fields query param for client_secret. This will be set to a specific value if the permissions is available, otherwise it will be an empty string.📚 References
auth0_client_credentialsrequiresread:client_secretpermissions #774🔬 Testing
Tested manually, as our automated tests rely on the full set of permissions to run.
📝 Checklist