Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-838: Add support for map_user_id_to_id on connection resource options #840

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

sergiught
Copy link
Contributor

馃敡 Changes

Add support for map_user_id_to_id on connection resource options. This option can only be set on create, afterwards it can't be motified any longer. Because of this adding a ForceNew was considered, however it seemed a bit heavy handed to delete the entire connection and recreate it just because of this parameter.

馃摎 References

馃敩 Testing

馃摑 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner September 19, 2023 09:46
@codecov-commenter
Copy link

Codecov Report

Merging #840 (0416923) into v1 (fd294eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #840   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          99       99           
  Lines       13696    13699    +3     
=======================================
+ Hits        12306    12309    +3     
  Misses        987      987           
  Partials      403      403           
Files Changed Coverage 螖
internal/auth0/connection/expand.go 92.07% <100.00%> (+0.01%) 猬嗭笍
internal/auth0/connection/flatten.go 79.56% <100.00%> (+0.02%) 猬嗭笍

@sergiught sergiught merged commit 8012cfd into v1 Sep 19, 2023
6 checks passed
@sergiught sergiught deleted the GH-838-google-map-id-to-id branch September 19, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants