Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "scopes" required for Okta Workforce Connections #945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrianosela
Copy link

馃敡 Changes

Sometime in October 2023, the behavior of the Auth0 API changed. It used to automatically set the scopes openid and profile for all new Okta Workforce enterprise connections (the okta strategy).

The API simply stopped doing that - there is no docs to support this claim other than evidence (personal and other folks in the linked GitHub issue).

This change makes it so that the engineer making changes will see the error instead of their customers...

Creating an Okta workforce without the openid claim results in anyone trying to authenticate with this connection seeing the error:

Cannot read properties of undefined (reading 'trim')

Here's a screenshot from one of my very-unhappy customers:

image

馃摎 References

Closes #852

馃敩 Testing

N/A

馃摑 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@adrianosela adrianosela requested a review from a team as a code owner April 10, 2024 17:50
@adrianosela
Copy link
Author

Note that there should likely be documentation change to mention required scopes in https://auth0.com/docs/authenticate/identity-providers/enterprise-identity-providers/okta

And perhaps the auth0 API should reject Okta Workforce connections being created without scopes...

.... OR simply go back to the previous behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Okta Workforce Connection Bug: Cannot read properties of undefined (reading 'trim')
1 participant