Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PHP 8.0+ compatibility improvements #878

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

PeterGFernandez
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Change made to the WP_Auth0_Nonce_Handler class to refactoring access on function __wakeup() from private to public, in support of PHP 8. According to the documentation here, E_WARNING is now emitted for __wakeup() and the like where previously it was not.

Testing

Tested against latest installable plugin from the Wordpress site.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@PeterGFernandez PeterGFernandez requested a review from a team as a code owner August 21, 2023 18:23
@evansims evansims merged commit e1f9ee5 into auth0:4.x Nov 6, 2023
@evansims evansims changed the title 4.x refactor access specifier refactor: Access specifier Jan 11, 2024
@evansims evansims changed the title refactor: Access specifier refactor: PHP 8.0+ compatibility improvements Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants