Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Resend verification email only for DB connections #345

Closed
nicosabena opened this issue Aug 24, 2017 · 4 comments
Closed

Provide Resend verification email only for DB connections #345

nicosabena opened this issue Aug 24, 2017 · 4 comments
Assignees
Milestone

Comments

@nicosabena
Copy link
Member

AD/LDAP connections (and maybe others) can have unverified email addresses, but the verify email action only works for DB connections. So the link to Resend verification email should only be shown to users coming from a DB connection.

API v1's send_verification_email does not check that, but the link sent by email will cause an error when the user tries to use it.

@joshcanhelp joshcanhelp self-assigned this Jan 24, 2018
@joshcanhelp
Copy link
Contributor

@nicosabena - I'll suppress that link on our end. It sounds like that should be added to the job API request, if possible, like "email verification not possible" ... which it actually looks like it does already:

https://auth0.com/docs/api/management/v2#!/Jobs/post_verification_email

I'll get this into the next release.

@joshcanhelp joshcanhelp modified the milestone: v3-Next Jan 25, 2018
@joshcanhelp joshcanhelp added this to the v3-Next milestone Apr 13, 2018
@joshcanhelp
Copy link
Contributor

@nicosabena - I've got this working now and ready for review but want to get your input on what happens if someone is not verified and also not a DB connection. We discussed have a way to skip email verification for certain connections, something I can look at for a future release. But, in the meantime, here's what they would see:

screenshot 2018-04-17 16 21 51

Not too terribly helpful.

So, in the case we're trying to catch here, what's a good next action or helpful text we could provide?

@nicosabena
Copy link
Member Author

The thing is, some identity providers (especially enterprise ones, like SAML) don't provide an email_verified claim/attribute at all. And, in an enterprise environment, the concept of verifying an email doesn't even make sense (the account is created for an employee working at a company, so they are all assumed to be verified), so the above text might not be really meaningful for users.

And when an Auth0 admin creates a connection to an enterprise IdP that doesn't provide the email_verified claim, there's no good way of saying "Hey, we can assume that all users coming from this connection have their email verified".

I know we are approaching the problem from the wrong side (this should probably be fixed both in the core server and in API v2 to support verifying users coming from upstream identity providers), but telling users to "Please verify your email and log in again" won't help much.

Maybe only leave "The site requires a verified email to log in", and have the administrator decide if they want to remove that restriction if they use anything other than database connections.

@joshcanhelp
Copy link
Contributor

Fixed in #447 and merged into dev

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants