Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show email verification resend for DB connections #447

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

joshcanhelp
Copy link
Contributor

Looks for auth0 strategy on the user ID and only shows the "Resend verification email" link if there.

Fixes #345

@joshcanhelp joshcanhelp added this to the v3-Next milestone Apr 23, 2018
__( '← Login', 'wp-auth0' ),
esc_url( admin_url( 'admin-ajax.php' ) ),
esc_js( $user_id ),
esc_js( wp_create_nonce( self::RESEND_NONCE_ACTION ) ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're using the jobs re-send email endpoint. The request only requires user_id and client_id properties. What is the nonce for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbalmaceda - WP thing to make sure that POSTed data is coming from the site. It's validated in the AJAX callback.

@lbalmaceda lbalmaceda self-requested a review April 25, 2018 21:16
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit e01a4fb into dev Apr 25, 2018
@joshcanhelp joshcanhelp deleted the fix-email-resend-for-db-connections branch April 25, 2018 21:24
@joshcanhelp joshcanhelp mentioned this pull request Jun 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants