Improve redirect_login error logging, JWT leeway #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added leeway to JWT decoding
cocojoe
force-pushed
the
added-updated-login-jwt-leeway-error-handling
branch
from
3e8303c
to
3363a79
Compare
|
|
glena
approved these changes
May 22, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWTDecode exceptions are now caught and logged in Auth0 Error Log, which should aid CS in debugging in general. A leeway (could be increased) for clock skew has been added to iat, nbf and exp claims.
Related to a current ZD Ticket