Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api_audience settings field #422

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Conversation

joshcanhelp
Copy link
Contributor

This field was for an audience value used with the Management API. This
value should never change and should not be user-configurable.

The render function is public but has only been around for a short
period of time so I don't think it's necessary to deprecate officially.

This field was for an audience value used with the Management API. This
value should never change and should not be user-configurable.
@joshcanhelp joshcanhelp added this to the v3-Next milestone Mar 28, 2018
@joshcanhelp joshcanhelp self-assigned this Mar 28, 2018
@cocojoe
Copy link
Member

cocojoe commented Apr 4, 2018

@lbalmaceda any issue with this?

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@joshcanhelp joshcanhelp merged commit dc36353 into dev Apr 5, 2018
@joshcanhelp joshcanhelp deleted the remove-audience-field branch April 5, 2018 16:21
@joshcanhelp joshcanhelp mentioned this pull request Jun 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants