Change Basic settings field display; better admin UX #433
Conversation
joshcanhelp
commented
Apr 16, 2018
joshcanhelp
commented
- Refactored Basic settings with new render functions, new descriptions
- Fixed PHP < 5.4 array style for advanced render functions
- Persist tab showing on settings page
- Universal show/hide JS for switch fields
- Constant for JWKS cache transient name
| // Show/hide field for specific switches | ||
| $('[data-expand!=""]').each( function() { | ||
| var $thisSwitch = $( this ); | ||
| var $showFieldRow = $( '#' + $thisSwitch.attr( 'data-expand' ) ).closest( 'tr' ); |
There was a problem hiding this comment.
Length is always there for a jQuery selector. Next line checks that
There was a problem hiding this comment.
I meant the "data-expand" and then "closest TR".
There was a problem hiding this comment.
Having data-expand is what gets you into the each here. No data-expand, no each
assets/js/admin.js
Outdated
| function localStorageAvailable() { | ||
| try { | ||
| var x = '__storage_test__'; | ||
| window.localStorage.setItem(x, x); |
There was a problem hiding this comment.
is this try/catch the only way to check for availability? And, can the removeItem fail after the first one succeeded?
There was a problem hiding this comment.
No, but it's the best way:
As for removeItem, that would be a weird case, not implementing the webStorage interface. But localStorage persist forever and we don't want to store something we're never going to use.
There was a problem hiding this comment.
is this stored under some domain key or can it collide with existing "x" stored keys? In that case, you might want to use some key like "a0_local_storage_assertion"
There was a problem hiding this comment.
It's per-domain:
https://stackoverflow.com/q/4201239/728480
But you have a good point about that. WP sites could load a million other JS libraries.
lib/admin/WP_Auth0_Admin_Basic.php
Outdated
| public function render_client_secret_b64_encoded( $args = array() ) { | ||
| $this->render_switch( $args['label_for'], $args['opt_name'] ); | ||
| $this->render_field_description( | ||
| __( 'Enable this if your Client Secret is base64 enabled. ', 'wp-auth0' ) . |
There was a problem hiding this comment.
Why did I say "enabled" here? 😆
Fixed!
| $this->render_field_description( | ||
| sprintf( '<a href="https://%s/.well-known/jwks.json" target="_blank">%s</a>', | ||
| $domain, | ||
| __( 'View your JWKS here', 'wp-auth0' ) |
There was a problem hiding this comment.
Would this section show the JWKs contents or what?
There was a problem hiding this comment.
Links to it, yes.
joshcanhelp
force-pushed
the
change-settings-fields-display-pt-2
branch
from
23de224
to
c5b6c64
Compare
